Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Ferroin
Copy link
Member

@Ferroin Ferroin commented Oct 14, 2025

Summary
  • Instead of rolling our own CPP-safe escaping routine, just use CMake’s built-in functionality for this. This makes our code a bit tidier, and the CMake provided implementation covers a number of cases that our in-house implementation did not.
  • Use the CMakePushCheckState module to better isolate the state used during individual checks from each other. THis should help avoid obscure bugs resulting from state being leaked between checks.

Both of these are bringing things more in-line with best practices for CMake code.

Test Plan

CI still passes on this PR without issue.

This makes our code slightly tidier, and also covers a number of cases
that our initial implementation did not.
This helps ensure that additional configuration required for specific
individual checks doesn’t spill over to other checks.
@github-actions github-actions bot added area/packaging Packaging and operating systems support area/build Build system (autotools and cmake). labels Oct 14, 2025
@Ferroin Ferroin marked this pull request as ready for review October 16, 2025 14:02
@Ferroin Ferroin requested review from a team and vkalintiris as code owners October 16, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/build Build system (autotools and cmake). area/packaging Packaging and operating systems support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant