Improve websocket thread shutdown #21264
Open
+54
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enhances websocket thread shutdown to prevent indefinite hangs and improve error handling during server shutdown. Adds timeout protection, non-blocking I/O configuration, and comprehensive error handling to ensure graceful and predictable shutdown behavior.
Problem
During server shutdown, the websocket thread cleanup could hang indefinitely when attempting to send close frames to unresponsive clients. This was caused by:
This could delay or prevent clean server shutdown, especially under high load or network issues.