fix(go.d/proxysql): correct backend status metric mapping#21524
Merged
ilyam8 merged 1 commit intonetdata:masterfrom Jan 8, 2026
Merged
fix(go.d/proxysql): correct backend status metric mapping#21524ilyam8 merged 1 commit intonetdata:masterfrom
ilyam8 merged 1 commit intonetdata:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the ProxySQL go.d collector where backend status metrics were incorrectly mapped. The collector was comparing ProxySQL's string status values (e.g., "ONLINE", "SHUNNED") against numeric codes ("1"-"4"), causing all status metrics to incorrectly report as 0.
Key Changes:
- Updated status comparison logic to match string values instead of numeric codes
- Corrected test expectations to reflect accurate status reporting
- All four status states (ONLINE, SHUNNED, OFFLINE_SOFT, OFFLINE_HARD) now properly detected
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/go/plugin/go.d/collector/proxysql/collect.go | Changed status comparison from numeric codes to string matching using a loop over known states |
| src/go/plugin/go.d/collector/proxysql/collector_test.go | Updated test expectations so status metrics now correctly show 1 when matched (instead of always 0) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
stelfrag
approved these changes
Jan 8, 2026
stelfrag
pushed a commit
to stelfrag/netdata
that referenced
this pull request
Jan 9, 2026
) (cherry picked from commit 8ea58d7)
stelfrag
pushed a commit
to stelfrag/netdata
that referenced
this pull request
Jan 9, 2026
) (cherry picked from commit 8ea58d7)
Merged
Ferroin
pushed a commit
that referenced
this pull request
Jan 12, 2026
(cherry picked from commit 8ea58d7)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes how the ProxySQL go.d collector derives per-backend
status_*metrics fromstats_mysql_connection_pool.ProxySQL returns status as a string (e.g.
ONLINE,SHUNNED,OFFLINE_SOFT,OFFLINE_HARD), but the collector was comparing it to numeric codes ("1".."4"), causing all status metrics to be reported as 0.Update the collector to set
backend_*_status_<STATE>based onvalue == <STATE>for the known states.Test Plan
Additional Information
For users: How does this change affect me?
Summary by cubic
Fixes ProxySQL backend status mapping in the go.d collector. Status metrics now match the string states returned by ProxySQL, fixing the 0-only values.
Written for commit f9f5aa6. Summary will update on new commits.