Fix logic for determining when to use $releasever_major. #21610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using it on any version of RHEL greater than 8.0, it needs to be used for any version greater than or equal to 9.0.
Contributor
There was a problem hiding this comment.
1 issue found across 3 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="packaging/repoconfig/rpm.changelog">
<violation number="1" location="packaging/repoconfig/rpm.changelog:1">
P2: Changelog entry is missing the release version suffix (e.g., "5-4"), which breaks the standard RPM changelog format used in this file.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the logic for determining when to use $releasever_major in RHEL repository configurations. Previously, it was incorrectly applied to RHEL versions > 8.0 (which included RHEL 8.x), but it should only be used for RHEL >= 9.0.
Changes:
- Updated version comparison logic to use
$releasever_majoronly for RHEL >= 9, keeping RHEL 8 on$releasever - Removed
yum-plugin-prioritiesdependency for RHEL 8 (now only required for RHEL < 8) - Bumped package release version from 5-3 to 5-4
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packaging/repoconfig/CMakeLists.txt | Updated RHEL version comparison logic and package dependencies; bumped PACKAGE_RELEASE to 4 |
| packaging/repoconfig/rpm.changelog | Added changelog entry for the logic fix (missing version number) |
| packaging/repoconfig/deb.changelog | Added version 5-4 entry to keep in sync with RPM packages |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
ilyam8
approved these changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Instead of using it on any version of RHEL greater than 8.0, it needs to be used for any version greater than or equal to 9.0.
Test Plan
Confirm that repository configuration packages for RHEL 8 don’t use
$releasever_major. Packages can be built from this branch by running thepackaging/repoconfig/build-rpm.shscript on a Rocky Linux 8 or Alma Linux 8 system (CentOS Stream 8 WILL NOT WORK FOR THIS).Additional Information
Fixes: #21609
Summary by cubic
Use $releasever_major in RPM repo URLs only on RHEL 9+, keeping RHEL 8 on $releasever. Also drop yum-plugin-priorities for RHEL 8 (default to epel-release) and bump the repo config package to 5-4, fixing #21609.
Written for commit 1ba2fa8. Summary will update on new commits.