Merged
Conversation
- Enhance logging if proxy is used (with or without credentials)
…y` helper function. - Simplify and unify proxy display construction in ACLK logging. - Adjust key name in JSON payload from `aclk-proxy` to `aclk_proxy`.
…play` helper function.
…trrchr` in `aclk_proxy_get_display`.
Contributor
There was a problem hiding this comment.
No issues found across 7 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Architecture diagram
sequenceDiagram
participant Config as Cloud Config (cloud-conf.c)
participant Proxy as ACLK Proxy Helper (aclk_proxy.c)
participant Net as Network Clients (HTTPS/MQTT)
participant Logs as System Logs / State API
Note over Config,Logs: Proxy Configuration & Initialization
Proxy->>Config: Get proxy setting
Config-->>Proxy: Return "env", URL, or "none"
Config->>Config: NEW: Track source (cloud.conf vs netdata.conf)
alt Proxy is "env"
Proxy->>Proxy: Check http_proxy/https_proxy
Proxy->>Logs: NEW: Log source as 'environment variable'
else Proxy is URL
Proxy->>Proxy: CHANGED: Parse credentials using LAST '@'
Proxy->>Logs: NEW: Log proxy protocol, host, and source
end
Note over Config,Logs: Connection Runtime Flow
Net->>Proxy: Fetch proxy settings
Proxy-->>Net: Return type and host info
Net->>Proxy: NEW: aclk_proxy_get_display()
Proxy-->>Net: Return redacted string (proto://host:port)
Net->>Logs: CHANGED: Log "connecting via proxy [proto][host]:[port]"
Net->>Logs: NEW: Explicitly log if "with credentials" or "without credentials"
alt Success
Net->>Net: Establish TCP/SSL connection
else Proxy Error (HTTP 401/407/5xx)
Net->>Logs: NEW: Log detailed failure including proxy address and status code
end
Note over Config,Logs: Monitoring / Reporting
Logs->>Proxy: aclk_state() or aclk_state_json()
Proxy->>Proxy: NEW: aclk_proxy_get_full_display()
Proxy-->>Logs: Return string: "host:port (credentials, from source)"
thiagoftsm
approved these changes
Feb 20, 2026
kanelatechnical
added a commit
that referenced
this pull request
Feb 24, 2026
Add troubleshooting section explaining new log formats for ACLK proxy connection messages that will be available starting from nightly build 2026-02-20. - Document proxy resolution messages (no proxy, explicit none, env vars) - Document connection time messages (MQTT WSS, HTTPS, OTP/challenge) - Document error messages (CONNECT failed, proxy response errors) - Document state reporting format changes - Add interpretation guide for common issues - Link to related security documentation These new log formats will help users diagnose ACLK proxy configuration issues more easily by showing exactly which proxy configuration is being used and where it came from. Related to PR #21789 (internal ACLK logging improvements)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Summary by cubic
Improved ACLK proxy logging and reporting across HTTPS and MQTT. Logs now show protocol, host:port, whether credentials are used, and where the proxy setting came from. Clear messages when no proxy is used or when env proxies are missing.
New Features
Bug Fixes
Written for commit 5a8dadc. Summary will update on new commits.