Conversation
There was a problem hiding this comment.
1 issue found across 1 file
Confidence score: 4/5
- This PR looks safe to merge overall; the only concern is a moderate issue around user setup in the Windows packaging script.
packaging/windows/package-windows.shonly checks for the passwd file, so a missingnobodyentry can persist and keep the original failure mode in some environments.- Pay close attention to
packaging/windows/package-windows.sh- ensure thenobodyentry is added when absent even if the passwd file already exists.
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packaging/windows/package-windows.sh">
<violation number="1" location="packaging/windows/package-windows.sh:54">
P2: Only checking for the passwd file’s existence can leave the `nobody` user missing when the file already exists. This keeps the original failure mode. Check for the `nobody` entry instead so it is added when absent.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
|
@thiagoftsm On Windows, we bypass ndexe and execute commands directly. The error shown in the description is no longer present in the latest stable release. |
Hello @ilyam8 , I had a meeting last Friday with a user, and he showed us in his cloud dashboard two errors: Error
Job check failed: error on quering XML GPU info: RunUnprivileged: C:\Program Files\Netdata\usr\bin\nd-run.exe C:\windows\system32\nvidia-smi.exe -q -x: exit status 1 (stderr: Fallback user 'nobody' not found either)[1:34 PM]ither)
Error
Job initialization failed: init intelgpu top exec: ndsudo executable not found: GetFileAttributesEx C:\Program Files\Netdata\usr\libexec\netdata\plugins.d\ndsudo: The system cannot find the file specified.According to him, GPU is only showing errors like this and it is not working at all. |
|
Let me repeat: on Windows, we bypass nd-run.exe and execute commands directly. The error shown in the description is no longer present in the latest stable release.
Is different and has nothing to do with "missing user", I will check. |
This is the reason the PR was made. |
Summary
When running installer on Windows, it is possible to find some issues like:
cpu.temperaturechart.This PR fixes all these issues.
Test Plan
After installation:
Additional Information
For users: How does this change affect me?
Summary by cubic
Enables and hardens the Windows hardware info driver to stabilize CPU temperature charts. Also updates the installer and module metadata for a smoother Windows setup.
Written for commit 4327cb7. Summary will update on new commits.