Refactor UID/GID cache updates in apps plugin aggregation logic#21864
Open
stelfrag wants to merge 1 commit intonetdata:masterfrom
Open
Refactor UID/GID cache updates in apps plugin aggregation logic#21864stelfrag wants to merge 1 commit intonetdata:masterfrom
stelfrag wants to merge 1 commit intonetdata:masterfrom
Conversation
- Relocate `update_cached_host_users()` and `update_cached_host_groups()` calls outside per-PID loops to optimize and simplify code structure. - Remove redundant updates within conditional blocks.
thiagoftsm
approved these changes
Mar 3, 2026
Contributor
thiagoftsm
left a comment
There was a problem hiding this comment.
Apps is working as expected after few hours. LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
update_cached_host_users()andupdate_cached_host_groups()calls outside per-PID loops to optimize and simplify code structure.Summary by cubic
Refactored apps plugin aggregation to refresh UID/GID caches once per cycle instead of per process, removing redundant updates and reducing overhead. Simplifies control flow by moving cache updates before the PID loop.
Written for commit e05beaa. Summary will update on new commits.