Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore(deps-dev): bump @vitest/eslint-plugin to 1.3.20 (supersedes #7701)#8305

Open
jherr wants to merge 1 commit into
mainfrom
chore/bump-vitest-eslint-plugin-1.3.20
Open

chore(deps-dev): bump @vitest/eslint-plugin to 1.3.20 (supersedes #7701)#8305
jherr wants to merge 1 commit into
mainfrom
chore/bump-vitest-eslint-plugin-1.3.20

Conversation

@jherr

@jherr jherr commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Standalone replacement for #7701, applied directly on top of main.

Why not just merge #7701

#7701 (renovate/vitest-eslint-plugin-1.x) was branched against an older tree pinned to vitest 3.2.4 and conflicts with main. Merging it would downgrade vitest. This PR applies only its intent — the @vitest/eslint-plugin 1.3.13 → 1.3.20 bump — with no other version changes.

Changes

  • @vitest/eslint-plugin → 1.3.20. Its @typescript-eslint ^8.46.1 dependency resolves as a nested subtree, so the top-level typescript-eslint stays at 8.45.0 and vitest stays at 3.2.4.
  • 1.3.20 enables the prefer-called-exactly-once-with rule; the 5 flagged assertions across 3 test files are collapsed into toHaveBeenCalledExactlyOnceWith(...) (eslint --fix + prettier).

No .npmrc / legacy-peer-deps needed — this is purely on vitest 3.

Verification

Local (Node 24): lint, typecheck, format:check pass; 373/373 unit tests pass. Integration/e2e not run locally (need auth token / network / Git LFS).

Closes #7701.

🤖 Generated with Claude Code

@jherr @claude
chore(deps-dev): bump @vitest/eslint-plugin to 1.3.20 (supersedes #7701)
e8d29c0 
Applies the intent of #7701 directly on top of main instead of merging
that stale branch, which would have downgraded vitest to 3.2.4. The
^8.46.1 @typescript-eslint dependency resolves as a nested subtree, so
the top-level typescript-eslint stack stays at 8.45.0 and vitest at
3.2.4. No .npmrc needed.

1.3.20 enables the prefer-called-exactly-once-with rule; the flagged
test assertions are collapsed into toHaveBeenCalledExactlyOnceWith via
eslint --fix + prettier.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
@jherr jherr requested a review from a team as a code owner June 15, 2026 19:47
@coderabbitai

coderabbitai Bot commented Jun 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b51774f6-c206-4c61-b5dc-c256982997ba

📥 Commits

Reviewing files that changed from the base of the PR and between 30ba6a1 and e8d29c0.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (4)
  • package.json
  • tests/unit/lib/completion/generate-autocompletion.test.ts
  • tests/unit/lib/functions/registry.test.ts
  • tests/unit/utils/init/config-github.test.ts
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • netlify/blueprints (manual)
📝 Walkthrough

Summary by CodeRabbit

  • Chores

    • Updated development dependency versions.

  • Tests

    • Improved test assertions for enhanced validation accuracy.

Walkthrough

The @vitest/eslint-plugin development dependency in package.json is bumped from 1.3.13 to 1.3.20. Three test files are updated to comply with the updated plugin: generate-autocompletion.test.ts, registry.test.ts, and config-github.test.ts each replace separate toHaveBeenCalledOnce() plus toHaveBeenCalledWith(...) assertion pairs with a single toHaveBeenCalledExactlyOnceWith(...) call at four assertion sites total.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: bumping @vitest/eslint-plugin to 1.3.20 and references the superseded PR #7701.
Description check ✅ Passed The description clearly explains why this PR exists as a replacement for #7701, the version change, dependency resolution behavior, and the test refactoring work performed.
Linked Issues check ✅ Passed The PR meets the objective from #7701 to bump @vitest/eslint-plugin from 1.3.13 to 1.3.20, and additionally refactors 5 test assertions across 3 files to use the new prefer-called-exactly-once-with rule.
Out of Scope Changes check ✅ Passed All changes are in scope: package.json version bump and test assertion refactorings required by the new ESLint rule enabled in 1.3.20.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/bump-vitest-eslint-plugin-1.3.20

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install failed due to a network error.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown

📊 Benchmark results

Comparing with 30ba6a1

  • Dependency count: 1,127 (no change)
  • Package size: 379 MB (no change)
  • Number of ts-expect-error directives: 353 (no change)

@jherr jherr mentioned this pull request Jun 15, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaredm563 jaredm563 jaredm563 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jherr @jaredm563