Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jun 9, 2025. It is now read-only.

feat: add API authentication support #217

Merged
merged 19 commits into from
Nov 17, 2021
Merged

feat: add API authentication support #217

merged 19 commits into from
Nov 17, 2021

Conversation

sgrove
Copy link
Contributor

@sgrove sgrove commented Nov 16, 2021 •
edited
Loading

A continuation of the work done in #104 that adds in dynamic fetching of secrets, and lays the groundwork for some backend changes coming to how the secrets will be passed in to functions in the future.

@sgrove sgrove requested review from tiffafoo and ascorbic November 16, 2021 16:36
@sgrove sgrove added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Nov 16, 2021
ascorbic
ascorbic reviewed Nov 16, 2021
View reviewed changes
Copy link
Contributor

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I haven't tested the typings though, so they will need to be looked at.

@ascorbic ascorbic changed the title Feat/secrets handling dynamic feat: add API authentication support Nov 17, 2021
ascorbic
ascorbic previously approved these changes Nov 17, 2021
View reviewed changes
Copy link
Contributor

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd like a serverless pod review before merging

eduardoboucas
eduardoboucas previously approved these changes Nov 17, 2021
View reviewed changes
Copy link
Member

@eduardoboucas eduardoboucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I left a few comments, but none of them are blocking.

@sgrove @eduardoboucas
chore: reject with error
c2d762d 
Co-authored-by: Eduardo Bouças <[email protected]>
@sgrove sgrove dismissed stale reviews from eduardoboucas and ascorbic via c2d762d November 17, 2021 11:27
@sgrove sgrove marked this pull request as ready for review November 17, 2021 11:32
@sgrove sgrove removed the request for review from tiffafoo November 17, 2021 11:42
eduardoboucas
eduardoboucas approved these changes Nov 17, 2021
View reviewed changes
Copy link
Member

@eduardoboucas eduardoboucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

ascorbic
ascorbic approved these changes Nov 17, 2021
View reviewed changes
Copy link
Contributor

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@kodiakhq kodiakhq bot merged commit 57ff1da into netlify:main Nov 17, 2021
@emilyzhang emilyzhang mentioned this pull request Nov 17, 2021
Merged
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ascorbic ascorbic ascorbic approved these changes

@eduardoboucas eduardoboucas eduardoboucas approved these changes

@netlify-team-account-1 netlify-team-account-1 Awaiting requested review from netlify-team-account-1

Assignees
No one assigned
Labels
automerge type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sgrove @ascorbic @eduardoboucas