This repository was archived by the owner on Jun 9, 2025. It is now read-only.
feat: publish ESM version #473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5028b28 to
c8a71ed
Compare
Skn0tt
previously approved these changes
Feb 13, 2024
|
Oh, the tests are failing because rollup doesn't support Node 14! I may need to change how the test is run, to build with latest then test with 14 |
ascorbic
commented
Feb 13, 2024
Comment on lines
+37
to
+48
| - name: Build | ||
| run: npm run build | ||
| - name: Node.js ${{ matrix.node-version }} | ||
| uses: actions/setup-node@v3 | ||
| if: "${{ matrix.node-version != '*' }}" | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| cache: 'npm' | ||
| check-latest: true | ||
| - name: Install dependencies ${{ matrix.node-version }} | ||
| run: npm ci | ||
| if: "${{ matrix.node-version != '*' }}" |
There was a problem hiding this comment.
Changing to always build on latest node, but still run tests on 14 if specified. This is because latest rollup doesn't work on 14.
Skn0tt
approved these changes
Feb 13, 2024
kodiakhq bot
pushed a commit
that referenced
this pull request
Feb 13, 2024
🤖 I have created a release *beep* *boop* --- ## [2.6.0](v2.5.1...v2.6.0) (2024-02-13) ### Features * publish ESM version ([#473](#473)) ([b1b7553](b1b7553)) ### Bug Fixes * **deps:** update dependency @netlify/serverless-functions-api to v1.13.1 ([#462](#462)) ([29b33ae](29b33ae)) * **deps:** update dependency @netlify/serverless-functions-api to v1.14.0 ([#470](#470)) ([c77eb33](c77eb33)) * skip purgeCache in local dev ([#472](#472)) ([9236053](9236053)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: token-generator-app[bot] <82042599+token-generator-app[bot]@users.noreply.github.com>
2 tasks
mrstork
added a commit
that referenced
this pull request
May 3, 2024
🎉 Thanks for sending this pull request! 🎉 Please make sure the title is clear and descriptive. If you are fixing a typo or documentation, please skip these instructions. Otherwise please fill in the sections below. **Which problem is this pull request solving?** Adding `@netlify/functions/internal` to export paths **List other issues or pull requests related to this problem** Follow-up to changes in #473 **Checklist** Please add a `x` inside each checkbox: - [x] I have read the [contribution guidelines](../blob/master/CONTRIBUTING.md). - [ ] The status checks are successful (continuous integration). Those can be seen below.
This was referenced Jun 7, 2024
This was referenced Sep 21, 2024
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this pull request solving?
This module doesn't currently publish an ESM version. It's hard to use this in ES modules, because it needs to be dynamically imported, but it imports node builtins that can't be dynamically imported.
Describe the solution you've chosen
This PR uses
tsupto build both cjs and esm. It also adds publint and arethetypeswrong to check the output, and removes the one-lineis-promiseCJS dependency.