Refactor and remove validation message handler #1196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1196 +/- ##
============================================
- Coverage 78.90% 77.94% -0.96%
- Complexity 1965 2085 +120
============================================
Files 172 202 +30
Lines 6352 6942 +590
Branches 1255 1266 +11
============================================
+ Hits 5012 5411 +399
- Misses 867 1063 +196
+ Partials 473 468 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the start of the breaking changes for 2.x. I think this should still be targeting JDK 8 and Jackson 2. When it's done then 3.x will be JDK 17 and Jackson 3 as Jackson 3 is min JDK 17.
This removes the validation message handler base class and fixes the class hierarchy of the JsonSchema and the rest of the validators. Previously JsonSchema had some of the validator methods like
getKeyword()andpreloadSchema()which was confusing as for JsonSchema to preload you had to callinitializeValidators()and it doesn't have a keyword.