This repository was archived by the owner on Jun 3, 2025. It is now read-only.
Server accepts file for pre-/post-processing functions#1033
Merged
Conversation
* Better Documentation
bfineran
reviewed
May 23, 2023
Updated documentation as requested by @bfineran
dbogunowicz
approved these changes
May 25, 2023
dbogunowicz
left a comment
Contributor
There was a problem hiding this comment.
Oh so this is what you've been working on. I like that!
One thing which is missing are some unit tests. Any plans to add those as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes code changes such that a custom pipeline, with custom pre-/post-processing functions can be created using the
deepsparse.serverdirectly. This enables a user to use our system without knowing anything about custom pipelinesAdditionally this PR also makes documentation updates, to expose this pathway.
Invocation:
And Voila! Now the server creates a custom pipeline, with custom pre-/post- processing functions from the specified
processing.pySpecial thanks to @bfineran for thinking about this pathway
And @dbogunowicz for #821 from which the loading functions code is inspired from
Additionally this pathway will become highly useful for
sparsify.packageCLI