Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jun 3, 2025. It is now read-only.

Require torchvision<0.14 rather than torchvision<=0.13#1034

Merged
mgoin merged 3 commits into
mainfrom
torchvision-0.13-hotfix
May 23, 2023
Merged

Require torchvision<0.14 rather than torchvision<=0.13#1034
mgoin merged 3 commits into
mainfrom
torchvision-0.13-hotfix

Conversation

@mgoin

@mgoin mgoin commented May 23, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

DeepSparse integration tests have been failing because we are restrictive on hotfix version for torchvision
We require torch==1.12.1 but restrict to torchvision==0.13 rather than allow 0.13.1

The conflict is caused by:
    deepsparse-nightly[dev,haystack,image-classification,server,transformers] 1.5.0 depends on torch==1.12.1; extra == "haystack"
    sentence-transformers 2.2.0 depends on torch>=1.6.0
    torchvision 0.13.0 depends on torch==1.12.0

https://github.com/neuralmagic/deepsparse/actions/runs/5010952108/jobs/8981291327

My proposed fix is to change torchvision>=0.3.0,<=0.13 to torchvision>=0.3.0,<0.14

Also, fix the SparseZoo change to use repo_name rather than model_id for the cache filepath

@mgoin mgoin requested review from a team, ohaijen, robertgshaw2-redhat and tdg5 and removed request for a team May 23, 2023 19:58
@mgoin mgoin merged commit 5f54cfc into main May 23, 2023
@mgoin mgoin deleted the torchvision-0.13-hotfix branch May 23, 2023 23:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ohaijen ohaijen Awaiting requested review from ohaijen

@tdg5 tdg5 Awaiting requested review from tdg5

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mgoin