This repository was archived by the owner on Jun 3, 2025. It is now read-only.
By default avoiding generating files in temp directory#1058
Merged
Conversation
dbogunowicz
commented
Jun 5, 2023
bfineran
previously approved these changes
Jun 9, 2023
bfineran
left a comment
Contributor
There was a problem hiding this comment.
LGTM overall, however not sure on naming "inplace" since that seems to imply the model is kept in memory to me
bfineran
approved these changes
Jun 13, 2023
rahul-tuli
approved these changes
Jun 13, 2023
rahul-tuli
left a comment
Member
There was a problem hiding this comment.
Noting here: Maybe a rebase is needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
conftestsso that after running any test target, the total size of files created after running the test suite can be: up to four new files for the root directory, and up to 150mb of created data for the temp directory./srcand/tests, made sure that when model's inputs are being altered, by default the happen changes "in-place"