This repository was archived by the owner on Jun 3, 2025. It is now read-only.
Update numpy version to latest#1094
Merged
Merged
Conversation
…ValueErrors when trying to convert ragged sequences
bfineran
approved these changes
Jun 26, 2023
This was referenced Jun 26, 2023
Closed
horheynm
pushed a commit
that referenced
this pull request
Jul 6, 2023
* Update numpy version to latest * Update problem line to use a helper that takes care of numpy raising ValueErrors when trying to convert ragged sequences
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates numpy support to latest
Needs the following pieces from sparsezoo and sparseml
Tested locally using the following code and numpy 1.24, including the changes from above two diffs:
Also ran all pipeline and transformer tests! They are green.
The problem only arises in
question-answeringpipeline due to computation ofspan_extra_infowhich involved a ragged sequence, supplying adtype=objectsolves this; this also seems feasible because earlier numpy versions(<=1.21) automatically converted a ragged sequence into an array of objects, which entails our codebase is already built to handle that case.