This repository was archived by the owner on Jun 3, 2025. It is now read-only.
Add kvcache support to debug_analysis.py and engine.py#1132
Merged
Conversation
SageMoore
reviewed
Jul 21, 2023
SageMoore
left a comment
Contributor
There was a problem hiding this comment.
This diff looks reasonable to me, Alex. I think once we resolve the formatting issues we should be good to merge.
48b20d5 to
bb6ba69
Compare
Contributor
Author
|
Formatting issues are resolved (thanks to Michael) |
bnellnm
reviewed
Jul 21, 2023
bnellnm
reviewed
Jul 21, 2023
bnellnm
reviewed
Jul 21, 2023
bnellnm
reviewed
Jul 21, 2023
bnellnm
left a comment
Member
There was a problem hiding this comment.
Overall looks good. Just a few minor comments
bnellnm
suggested changes
Jul 21, 2023
bnellnm
left a comment
Member
There was a problem hiding this comment.
I meant to hit "request changes" on my last round of comments. I couldn't figure out how to go back and change it.
bnellnm
reviewed
Jul 21, 2023
bnellnm
reviewed
Jul 21, 2023
bnellnm
previously approved these changes
Jul 21, 2023
mgoin
reviewed
Jul 21, 2023
bnellnm
approved these changes
Jul 21, 2023
mgoin
approved these changes
Jul 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ability to run kvcache via the debug_analysis.py.