This repository was archived by the owner on Jun 3, 2025. It is now read-only.
[bugfix] qa tests - KeyError: 'num_cores'#1152
Merged
Merged
Conversation
if num_cores is not an explicit kwarg of a bucketing pipeline it will trigger a key error on the changed line. this PR uses `.get` to default the value to `None` (this is the expected default of `Context`)
rahul-tuli
previously approved these changes
Jul 28, 2023
rahul-tuli
approved these changes
Jul 28, 2023
Satrat
approved these changes
Jul 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if num_cores is not an explicit kwarg of a bucketing pipeline it will trigger a key error on the changed line. this PR uses
.getto default the value toNone(this is the expected default ofContext)adds support for num_streams as well
test_plan
covered by pytest tests