This repository was archived by the owner on Jun 3, 2025. It is now read-only.
Conversation
added 2 commits
September 1, 2023 13:45
horheynm
commented
Sep 1, 2023
dbogunowicz
suggested changes
Sep 7, 2023
dbogunowicz
left a comment
Contributor
There was a problem hiding this comment.
Designwise looks great. Let's clean up the code, make it nicer in terms of style. Also, before landing let's make sure that all the tests in the new LLM testing harness pass:
This PR has potential to accidently break main pathways.
Contributor
|
Also, PR description missing, let's make the PR title more descriptive. |
bfineran
reviewed
Sep 7, 2023
Closed
mgoin
reviewed
Sep 8, 2023
added 2 commits
September 11, 2023 20:15
bfineran
previously approved these changes
Sep 12, 2023
dbogunowicz
previously approved these changes
Sep 13, 2023
Co-authored-by: dbogunowicz <[email protected]>
Contributor
|
tests unrelated, merging |
bfineran
approved these changes
Sep 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also need #1234 to land to check on failures caused by this pr if any