This repository was archived by the owner on Jun 3, 2025. It is now read-only.
[server] Update server routes to be compliant with MLServer#1237
Merged
Conversation
Satrat
reviewed
Sep 12, 2023
bfineran
previously approved these changes
Oct 6, 2023
bfineran
left a comment
Contributor
There was a problem hiding this comment.
LGTM - as mentioned before we need to sync w/ QA before landing
mgoin
reviewed
Oct 10, 2023
mgoin
left a comment
Member
There was a problem hiding this comment.
This seems like it would cause breaking changes to any application built using the old endpoint structure. I think if you could make a README or document showing how to transition current examples of usage, that would be helpful for other teams and users to have a summary of the changes.
For instance, how should we update this Digital Ocean getting started guide? https://marketplace.digitalocean.com/apps/deepsparse-inference-runtime
* refactor server for different integrations; additional functionality for chat completion streaming and non streaming * further refactor server * add support such that openai can host multiple models * update all tests * fix output for n > 1 * add inline comment explaining ProxyPipeline * [server] Update OpenAI Model Support (#1300) * update server * allow users to send requests with new models * use v1; move around baseroutes * add openai path * PR comments * clean-up output classes to be dataclasses, add docstrings, cleanup generation kwargs
Satrat
reviewed
Oct 10, 2023
bfineran
previously approved these changes
Oct 10, 2023
Satrat
previously approved these changes
Oct 10, 2023
Satrat
approved these changes
Oct 10, 2023
bfineran
approved these changes
Oct 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Testing
Sample Config:
This will now produce the following endpoints:
