This repository was archived by the owner on Jun 3, 2025. It is now read-only.
[Test] Make test_pipeline_call_is_async less problematic.#1251
Merged
Conversation
test_pipeline_call_is_async less problematic.
bfineran
approved these changes
Sep 18, 2023
Satrat
approved these changes
Sep 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing a unit test that very often breaks GHA and requires us to rerun the test suite. Unnecessary and wasteful.
The crux is that, even though the test makes sense, the margin of error is being set too harshly, especially when tests are not locally but in our CI/CD. Very often the difference between
dur_1_worker / dur_2_workeris1.89 or 1.88, which is more thanatol=0.1.By setting atol to
1.5we are still (roughly) checking the correctness, but we are being less strict and taking into consideration, that asynchronous calls sometimes do not behave as nicely as we would expect them.Edit: Also makes this test flaky, just for convenience.