This repository was archived by the owner on Jun 3, 2025. It is now read-only.
benchmarker API#1259
Merged
Merged
Conversation
bfineran
reviewed
Sep 20, 2023
bfineran
left a comment
Contributor
There was a problem hiding this comment.
Looks good overall - need a way to instantiate model and pipeline from other sources (ie files, kwargs, etc)
bfineran
reviewed
Sep 25, 2023
bfineran
left a comment
Contributor
There was a problem hiding this comment.
LGTM overall - the only thing I think would be missing is a way to pass an already instantiated pipeline object to benchmarker
something like:
my_pipeline = Pipeline.create(...)
benchmarker = Benchmarker(pipeline=my_pipeline)Co-authored-by: Benjamin Fineran <[email protected]>
bfineran
approved these changes
Sep 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trigger
deepsparse.benchmark
deepsparse.benchmark_pipeline
Example code in tests