This repository was archived by the owner on Jun 3, 2025. It is now read-only.
[Cherry-Pick][Text Generation] Terminate the inference when kv cache is full#1447
Merged
Conversation
… management (#1337) * initial commit * initial commit * cleanup * cleanup2
… into release/1.6
… into release/1.6
… into release/1.6
… into release/1.6
… into release/1.6
tlrmchlsmth
previously requested changes
Dec 1, 2023
dbogunowicz
commented
Dec 1, 2023
dsikka
previously requested changes
Dec 1, 2023
dsikka
left a comment
Contributor
There was a problem hiding this comment.
Could we add a test case to catch this case?
Satrat
approved these changes
Dec 1, 2023
Member
+1 |
rahul-tuli
approved these changes
Dec 1, 2023
rahul-tuli
left a comment
Member
There was a problem hiding this comment.
Approving to unblock release, @dbogunowicz will track this and add tests in main
Damian will add tests in main, landing this to unblock QA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick for #1446