This repository was archived by the owner on Jun 3, 2025. It is now read-only.
[Pipeline Refactor] Migration#1460
Merged
Merged
Conversation
e07d49a to
5abfc26
Compare
dbogunowicz
suggested changes
Dec 7, 2023
Contributor
There was a problem hiding this comment.
Few general inquires to @dsikka / @bfineran
- How in the future will the full "retirement" of V1 look like?
- I understand that once this PR lands, we stop any development of
legacycode - There are still two functionalities for V2 pipelines that need to land from my side: non-KV cache pipeline (ready for review) and streaming (WiP). Also there are small differences between V1 and V2 text generation pipeline (e.g. #1446). When do we want to get those in ASAP, to assert that V1 and V2 are identical?
dbogunowicz
previously approved these changes
Dec 8, 2023
bfineran
previously approved these changes
Dec 8, 2023
bfineran
left a comment
Contributor
There was a problem hiding this comment.
LGTM pending tests passing and confirmation that user facing scripts run as expected - examples look great
bfineran
approved these changes
Dec 8, 2023
dbogunowicz
approved these changes
Dec 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
legacyfolder undersrc. Old text_generation and image_classification folders were also moved tolegacysubfolders in their respective modulestransformers/schemasmaking it easy for both the new and old pipelines to pull them inTesting
Pipeline.create(...)method.Pipeline.create(...)as well. This will use the legacy pipeline class under the hood.Pipelineunderlegacy/pipeline.pyAll 3 examples are shown below.
Example:
Run the new text generation pipeline (with continuous batching, if that's what your heart desires):
Run the old text_generation pipeline:
Run any pipeline that has not yet been migrated to use the new
Pipelineclass/frameworkNext Steps
test_pipeline.pyandtest_dynamic_import.py). Right now they are testing the legacy pipeline.test_text_generation.pyneeds to be updated. It is currently testing the legacy pipeline.PIpeline.to_config/Pipeline.from_configsuch that new pipelines can be loaded in the server. Right now, only old pipelines can run on the server