This repository was archived by the owner on Jun 3, 2025. It is now read-only.
Using system_logging_config directly instead of using Depends#858
Merged
Conversation
dbarbuzzi
approved these changes
Jan 9, 2023
dbarbuzzi
left a comment
Contributor
There was a problem hiding this comment.
I can confirm that these changes resolve the issue that was occurring when testing the YOLO server example within the src/deepsparse/yolo/README.md.
bfineran
approved these changes
Jan 9, 2023
bfineran
left a comment
Contributor
There was a problem hiding this comment.
tentatively approving. @corey-nm do you know if there was a specific reason why Depends was needed? Otherwise would be good to check in with @dbogunowicz
Contributor
Author
|
Not sure, will wait on info from @dbogunowicz |
Contributor
|
Taking a look. |
dbogunowicz
pushed a commit
that referenced
this pull request
Mar 22, 2023
dbogunowicz
pushed a commit
that referenced
this pull request
Mar 22, 2023
bfineran
added a commit
that referenced
this pull request
Mar 22, 2023
…epends (#858) (1.4.2) (#973) * Using system_logging_config directly instead of using Depends (#858) * Update version.py --------- Co-authored-by: corey-nm <[email protected]> Co-authored-by: Benjamin Fineran <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To resolve issue of
Testing plan
Ran commands in yolo README.md