Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: Do not update dependencies in vendor-bin when removing nextcloud/ocp#538

Merged
nickvergessen merged 1 commit into
masterfrom
fix/remove-ocp-update-vendor-bin
Apr 28, 2025
Merged

fix: Do not update dependencies in vendor-bin when removing nextcloud/ocp#538
nickvergessen merged 1 commit into
masterfrom
fix/remove-ocp-update-vendor-bin

Conversation

@provokateurin

Copy link
Copy Markdown
Member

Fixes #537

The --no-scripts option ensures the post-update-cmd from the composer-bin plugin is not executed, so only the main composer.lock file will be updated. There doesn't seem to be a proper way to disable command forwarding for single commands with the composer-bin plugin.

@provokateurin provokateurin added 3. to review Waiting for reviews bug Something isn't working labels Apr 28, 2025
@nickvergessen

nickvergessen commented Apr 28, 2025

Copy link
Copy Markdown
Member

Another option is to only "install" instead of "update" when updating in main:
https://github.com/nextcloud/spreed/blob/main/composer.json#L34-L35

I changed that in basically all my apps already, as it's way too annoying that updating a single package updates all packages in all vendor-bins

@provokateurin

Copy link
Copy Markdown
Member Author

That makes sense. I will do that for my apps as well, but I think we should still merge this PR to ensure this doesn't happen to other apps that always update all bins as well.

@nickvergessen

Copy link
Copy Markdown
Member

I think we should still merge this PR

Agreed

@nickvergessen nickvergessen merged commit f13a4cd into master Apr 28, 2025
@nickvergessen nickvergessen deleted the fix/remove-ocp-update-vendor-bin branch April 28, 2025 08:43
max-nextcloud added a commit to nextcloud/collectives that referenced this pull request Jun 21, 2025
Include changes from nextcloud/.github#538
"Do not update dependencies in vendor-bin when removing nextcloud/ocp".

Signed-off-by: Max <[email protected]>
max-nextcloud added a commit to nextcloud/collectives that referenced this pull request Jun 23, 2025
Include changes from nextcloud/.github#538
"Do not update dependencies in vendor-bin when removing nextcloud/ocp".

Signed-off-by: Max <[email protected]>
mejo- pushed a commit to nextcloud/collectives that referenced this pull request Jun 23, 2025
Include changes from nextcloud/.github#538
"Do not update dependencies in vendor-bin when removing nextcloud/ocp".

Signed-off-by: Max <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Calling composer remove nextcloud/ocp --dev updates composer.lock files in vendor-bin

2 participants