Public NKTrash initializer #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary to make the initializer available outside of the NextcloudKit module, in example in test implementations of NextcloudFileProviderKit. Signed-off-by: Iva Horn <[email protected]>
marinofaggiana
approved these changes
Sep 11, 2025
mpivchev
reviewed
Sep 12, 2025
| public var trashbinOriginalLocation: String | ||
| public var trashbinDeletionTime: Date | ||
|
|
||
| public init(ocId: String = "", contentType: String = "", typeIdentifier: String = "", date: Date = Date(), directory: Bool = false, fileId: String = "", fileName: String = "", filePath: String = "", hasPreview: Bool = false, iconName: String = "", size: Int64 = 0, classFile: String = "", trashbinFileName: String = "", trashbinOriginalLocation: String = "", trashbinDeletionTime: Date = Date()) { |
Collaborator
There was a problem hiding this comment.
This needs to be increased, ill do it in my PR
Ask if possible to change this first
Collaborator
|
Probably should not have been merged yet. There are obvious Lint errors |
Collaborator
|
@i2h3 Is it possible to reduce the size of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary to make the initializer available outside of the NextcloudKit module, in example in test implementations of NextcloudFileProviderKit.