Fix Interpretation of Lock Responses #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the lock mechanism in NextcloudKit by changing from an object-oriented approach to a flattened property structure. The changes fix the interpretation of lock responses by properly handling numeric lock status values and making lock properties optional where appropriate.
- Changed lock representation from a single
NKLockobject to individual lock properties onNKFile - Fixed lock status parsing to use integer values instead of boolean interpretation
- Made
ownerEditoroptional inNKLockto handle cases where it may not be present
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| NKLock.swift | Updated lock parsing logic to handle integer status values and made ownerEditor optional |
| NKFile.swift | Replaced single lock object with individual lock properties for better data handling |
| NKDataFileXML.swift | Updated XML parsing to populate individual lock properties instead of creating lock objects |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Iva Horn <[email protected]>
c0ee0c3 to
790c208
Compare
marinofaggiana
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.