Merged
Conversation
1 flaky test on run #1375 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Check activity listing in the sidebar > Has favorite activity |
Test Replay
Screenshots
|
|
Review all test suite changes for PR #1616 ↗︎
Signed-off-by: Louis Chemineau <[email protected]>
cf3474c to
dd2e920
Compare
miaulalala
approved these changes
Apr 4, 2024
Collaborator
Author
|
/backport to stable29 |
Collaborator
Author
|
/backport to stable28 |
Collaborator
Author
|
/backport to stable27 |
This was referenced Apr 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to what we have in the web UI. I reused the existing logic which also allowed to removed some duplicate code.
Took the occasion to cleanup some typings in the touched files.