[stable30] fix: disable loading when there are no more activities to load#1933
Closed
backportbot[bot] wants to merge 1 commit intostable30from
Closed
[stable30] fix: disable loading when there are no more activities to load#1933backportbot[bot] wants to merge 1 commit intostable30from
backportbot[bot] wants to merge 1 commit intostable30from
Conversation
a380839 to
333e888
Compare
hamza221
approved these changes
Mar 20, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## stable30 #1933 +/- ##
============================================
- Coverage 30.89% 30.85% -0.04%
============================================
Files 43 43
Lines 1615 1617 +2
Branches 110 110
============================================
Hits 499 499
- Misses 1090 1092 +2
Partials 26 26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Activity
|
||||||||||||||||||||||||||||
| Project |
Activity
|
| Branch Review |
backport/1931/stable30
|
| Run status |
|
| Run duration | 04m 06s |
| Commit |
|
| Committer | backportbot[bot] |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
3
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
7
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
cypress/e2e/sidebar.cy.ts • 3 failed tests • Run E2E
333e888 to
544f359
Compare
AndyScherzinger
approved these changes
Mar 24, 2025
544f359 to
cbb6720
Compare
Signed-off-by: Hamza Mahjoubi <[email protected]>
cbb6720 to
7ba7f24
Compare
nickvergessen
requested changes
Apr 3, 2025
Member
nickvergessen
left a comment
There was a problem hiding this comment.
This just breaks combined activities: #1959
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #1931
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.