Revert "fix: disable loading when there are no more activities to load"#1958
Merged
nickvergessen merged 1 commit intostable29from Apr 3, 2025
Merged
Revert "fix: disable loading when there are no more activities to load"#1958nickvergessen merged 1 commit intostable29from
nickvergessen merged 1 commit intostable29from
Conversation
This reverts commit 520f4a5.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## stable29 #1958 +/- ##
============================================
+ Coverage 41.93% 41.96% +0.03%
============================================
Files 43 43
Lines 3842 3839 -3
Branches 110 110
============================================
Hits 1611 1611
+ Misses 2205 2202 -3
Partials 26 26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AndyScherzinger
approved these changes
Apr 3, 2025
Antreesy
approved these changes
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 520f4a5.
Without this pagination works totally fine. Otherwise pagination breaks when there was at least 1 grouped activity: #1931 (comment)
Steps to reproduce