Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix multiple cypress issues#1983

Merged
susnux merged 6 commits intomasterfrom
fix/noid/cypress-force-activity-tab
Apr 18, 2025
Merged

Fix multiple cypress issues#1983
susnux merged 6 commits intomasterfrom
fix/noid/cypress-force-activity-tab

Conversation

@SystemKeeper
Copy link
Contributor

@SystemKeeper SystemKeeper commented Apr 18, 2025 •
edited
Loading

Fixes:

  • Force click on activity tab, as it could be under a toast
  • Wait for preview to be generated, to ensure the file is not locked by preview generation
  • Reload the page after adding a comment (as is done for tags)
  • Don't stop containers on CI to extract nextcloud logs
  • Record video when job runs in debug mode
  • Reduce containers from 3 -> 2 as we only have 2 suites anyway (IMO it can also be just 1...)

@codecov
Copy link

codecov bot commented Apr 18, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.80%. Comparing base (dde1600) to head (a4683fd).
Report is 17 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1983   +/-   ##
=======================================
  Coverage   30.80%   30.80%           
=======================================
  Files          43       43           
  Lines        1620     1620           
  Branches      110      110           
=======================================
  Hits          499      499           
  Misses       1095     1095           
  Partials       26       26

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cypress
Copy link

cypress bot commented Apr 18, 2025 •
edited
Loading

Activity    Run #2513

Run Properties:  status check passed Passed #2513  •  git commit d59b9e1a97: fix(cypress): Force click on activity tab
Project Activity
Branch Review fix/noid/cypress-force-activity-tab
Run status status check passed Passed #2513
Run duration 02m 17s
Commit git commit d59b9e1a97: fix(cypress): Force click on activity tab
Committer Marcel Müller
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 10
View all changes introduced in this branch ↗︎

@SystemKeeper SystemKeeper force-pushed the fix/noid/cypress-force-activity-tab branch from d63aaac to 6d0573b Compare April 18, 2025 16:17
@SystemKeeper SystemKeeper force-pushed the fix/noid/cypress-force-activity-tab branch from 6096c15 to a4683fd Compare April 18, 2025 17:05
@SystemKeeper SystemKeeper changed the title fix(cypress): Force click on activity tab Fix multiple cypress issues Apr 18, 2025
@SystemKeeper SystemKeeper requested review from artonge and susnux April 18, 2025 17:10
@SystemKeeper SystemKeeper marked this pull request as ready for review April 18, 2025 17:12
@susnux susnux merged commit e9b0328 into master Apr 18, 2025
59 checks passed
@susnux susnux deleted the fix/noid/cypress-force-activity-tab branch April 18, 2025 17:26
@SystemKeeper SystemKeeper mentioned this pull request Apr 18, 2025
Merged
@artonge
Copy link
Collaborator

artonge commented Apr 22, 2025

/backport to stable31

@backportbot backportbot bot mentioned this pull request Apr 22, 2025
Merged
2 tasks
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes

@artonge artonge Awaiting requested review from artonge

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SystemKeeper @artonge @susnux