-
Notifications
You must be signed in to change notification settings - Fork 946
Migrate talk container to alpine #1583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks again for this PR @Zoey2936 ! :) Unfortunately I am not completely sure if we should go this way since the packages that we use for talk are well tested by morph027. Switching to compiling the signaling server ourselves and using alpine as base potentially intoduces a big maintenance burden that I am not sure if I want to take... What is your opinion on this? :) |
|
We could copy the signaling binary out of the official image: https://hub.docker.com/r/strukturag/nextcloud-spreed-signaling |
yes, that sounds like a good approach to me, thanks :) |
|
And should nats be pulled from alpine packages or their GitHub releases? @szaimen |
If nats is only an executable and there is an official image, we should best get it from there. Otherwise I would vote for getting it from the alpine packages. |
af5fc00 to
7456706
Compare
|
It will now pull signaling from the signaling image, nats from the nats image and run inside the coturn image, which is alpine based, only janus will be pulled from alpine, we only need to wait that janus can be pulled from alpine inside the coturn image and strukturag/nextcloud-spreed-signaling#384 gets merged and there is a new release |
All right, thanks a lot! :) |
7456706 to
3a22456
Compare
3f180c6 to
8997306
Compare
I suppose this might get included in alpine 3.18 or higher then... |
8a68809 to
5322f77
Compare
Signed-off-by: Zoey <[email protected]>
Signed-off-by: Zoey <[email protected]>
Signed-off-by: Zoey <[email protected]>
Signed-off-by: Zoey <[email protected]>
Signed-off-by: Zoey <[email protected]>
Signed-off-by: Zoey <[email protected]>
Signed-off-by: Zoey <[email protected]>
Signed-off-by: Zoey <[email protected]>
Signed-off-by: Zoey <[email protected]>
|
we could wait for coturn/coturn#1174 |
does this update the shipped alpine to 3.17 then? |
As the condition for an alpine 3.17 build was a new release, I would say yes |
Cool! Then yes, lets wait for it :) |
|
but are there other things that need to be changed? |
only #1583 (comment) afaics |
szaimen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works. Thank you very much! :)
how long would you say should we wait at max for this release? |
lets do this then in a follow-up and save the current state by merging it :) |
yes |
|
This is now released with v4.7.0 Beta. Testing and feedback is welcome! |
Signed-off-by: Zoey [email protected]
Needs: