Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Zoey2936
Copy link
Collaborator

@Zoey2936 Zoey2936 commented Dec 23, 2022

@Zoey2936 Zoey2936 requested a review from szaimen December 23, 2022 12:57
@szaimen szaimen added this to the next milestone Dec 23, 2022
@Zoey2936 Zoey2936 marked this pull request as draft December 23, 2022 13:08
@szaimen
Copy link
Collaborator

szaimen commented Dec 23, 2022

Thanks again for this PR @Zoey2936 ! :)

Unfortunately I am not completely sure if we should go this way since the packages that we use for talk are well tested by morph027. Switching to compiling the signaling server ourselves and using alpine as base potentially intoduces a big maintenance burden that I am not sure if I want to take...

What is your opinion on this? :)

@szaimen szaimen added 2. developing Work in progress enhancement New feature or request labels Dec 23, 2022
@Zoey2936
Copy link
Collaborator Author

We could copy the signaling binary out of the official image: https://hub.docker.com/r/strukturag/nextcloud-spreed-signaling
But it currently doesn't support multi arch, would this option be better for you? If yes, I create an PR on their GitHub repo, adding multi arch support.

@szaimen
Copy link
Collaborator

szaimen commented Dec 23, 2022

We could copy the signaling binary out of the official image: https://hub.docker.com/r/strukturag/nextcloud-spreed-signaling
But it currently doesn't support multi arch, would this option be better for you? If yes, I create an PR on their GitHub repo, adding multi arch support.

yes, that sounds like a good approach to me, thanks :)

@Zoey2936
Copy link
Collaborator Author

And should nats be pulled from alpine packages or their GitHub releases? @szaimen

@szaimen
Copy link
Collaborator

szaimen commented Dec 24, 2022

And should nats be pulled from alpine packages or their GitHub releases? @szaimen

If nats is only an executable and there is an official image, we should best get it from there. Otherwise I would vote for getting it from the alpine packages.

@Zoey2936 Zoey2936 force-pushed the migrate-talk-alpine branch 3 times, most recently from af5fc00 to 7456706 Compare December 24, 2022 17:25
@Zoey2936
Copy link
Collaborator Author

It will now pull signaling from the signaling image, nats from the nats image and run inside the coturn image, which is alpine based, only janus will be pulled from alpine, we only need to wait that janus can be pulled from alpine inside the coturn image and strukturag/nextcloud-spreed-signaling#384 gets merged and there is a new release

@szaimen
Copy link
Collaborator

szaimen commented Dec 26, 2022

It will now pull signaling from the signaling image, nats from the nats image and run inside the coturn image, which is alpine based, only janus will be pulled from alpine, we only need to wait that janus can be pulled from alpine inside the coturn image and strukturag/nextcloud-spreed-signaling#384 gets merged and there is a new release

All right, thanks a lot! :)

@Zoey2936 Zoey2936 force-pushed the migrate-talk-alpine branch from 7456706 to 3a22456 Compare December 28, 2022 14:31
@szaimen szaimen removed this from the next milestone Dec 29, 2022
@Zoey2936 Zoey2936 force-pushed the migrate-talk-alpine branch 2 times, most recently from 3f180c6 to 8997306 Compare January 6, 2023 13:56
@szaimen
Copy link
Collaborator

szaimen commented Jan 16, 2023

I suppose this might get included in alpine 3.18 or higher then...

@Zoey2936 Zoey2936 force-pushed the migrate-talk-alpine branch from 8a68809 to 5322f77 Compare January 21, 2023 22:24
@Zoey2936 Zoey2936 removed the request for review from szaimen February 4, 2023 19:22
@Zoey2936 Zoey2936 requested a review from szaimen March 16, 2023 16:22
@Zoey2936 Zoey2936 requested review from szaimen and removed request for szaimen March 17, 2023 08:19
@Zoey2936
Copy link
Collaborator Author

we could wait for coturn/coturn#1174

@szaimen
Copy link
Collaborator

szaimen commented Mar 21, 2023

we could wait for coturn/coturn#1174

does this update the shipped alpine to 3.17 then?

@Zoey2936
Copy link
Collaborator Author

we could wait for coturn/coturn#1174

does this update the shipped alpine to 3.17 then?

As the condition for an alpine 3.17 build was a new release, I would say yes

@szaimen
Copy link
Collaborator

szaimen commented Mar 21, 2023

we could wait for coturn/coturn#1174

does this update the shipped alpine to 3.17 then?

As the condition for an alpine 3.17 build was a new release, I would say yes

Cool! Then yes, lets wait for it :)

@Zoey2936
Copy link
Collaborator Author

but are there other things that need to be changed?

@szaimen
Copy link
Collaborator

szaimen commented Mar 21, 2023

but are there other things that need to be changed?

only #1583 (comment) afaics

Copy link
Collaborator

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works. Thank you very much! :)

@Zoey2936
Copy link
Collaborator Author

we could wait for coturn/coturn#1174

does this update the shipped alpine to 3.17 then?

As the condition for an alpine 3.17 build was a new release, I would say yes

Cool! Then yes, lets wait for it :)

how long would you say should we wait at max for this release?

@szaimen
Copy link
Collaborator

szaimen commented Mar 21, 2023

we could wait for coturn/coturn#1174

does this update the shipped alpine to 3.17 then?

As the condition for an alpine 3.17 build was a new release, I would say yes

Cool! Then yes, lets wait for it :)

lets do this then in a follow-up and save the current state by merging it :)

@Zoey2936
Copy link
Collaborator Author

we could wait for coturn/coturn#1174

does this update the shipped alpine to 3.17 then?

As the condition for an alpine 3.17 build was a new release, I would say yes

Cool! Then yes, lets wait for it :)

lets do this then in a follow-up and save the current state by merging it :)

yes

@szaimen szaimen merged commit af78a8f into main Mar 21, 2023
@delete-merged-branch delete-merged-branch bot deleted the migrate-talk-alpine branch March 21, 2023 17:39
@szaimen
Copy link
Collaborator

szaimen commented Mar 23, 2023

This is now released with v4.7.0 Beta. Testing and feedback is welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants