Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Nov 11, 2024

Works with Files app ✔

@tobiasKaminsky tobiasKaminsky marked this pull request as ready for review November 12, 2024 06:15
Signed-off-by: tobiasKaminsky <[email protected]>
@AndyScherzinger AndyScherzinger added the 4. to release Ready to be released and/or waiting for tests to finish label Nov 12, 2024
@AndyScherzinger AndyScherzinger added this to the 0.24.0 milestone Nov 12, 2024
@AndyScherzinger
Copy link
Member

Lacks bump of the other sub projects still being on 34

@tobiasKaminsky
Copy link
Member Author

tobiasKaminsky commented Nov 12, 2024

Lacks bump of the other sub projects still being on 34

I tested with integrating it in Files App and this works without problems:

implementation 'com.github.nextcloud:android-common:sdk35-SNAPSHOT'

So we can merge it.

In #543 is the problem that it enforced by minSDK, I suppose.
While we only use compileSDK.

@tobiasKaminsky tobiasKaminsky merged commit 3304045 into main Nov 12, 2024
14 checks passed
@tobiasKaminsky tobiasKaminsky deleted the sdk35 branch November 12, 2024 06:24
@tobiasKaminsky
Copy link
Member Author

@AndyScherzinger shall we do a release only with this change?

@AndyScherzinger
Copy link
Member

with this one and the ktx lib bump, yes I'd say let's ship v0.24.0

@AndyScherzinger
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants