-
Notifications
You must be signed in to change notification settings - Fork 2k
profiler docs: add version detection #12368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
does not work on ubuntu 24.04 |
6 month later, still not merged? |
Looks like. Have you seen my comment? |
You don't provide sufficient information. Better copy/paste the whole execution commands with the proper |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done required changes
This comment was marked as outdated.
This comment was marked as outdated.
In the previous command, the `|&` was not a typo but intentional. Was removed outside of github AFAIK. The output of `php occ version` is on `STDERR`. Anyway, now this is a POSIX way to detect version. Signed-off-by: Gilles Quénot <[email protected]>
Signed-off-by: Gilles Quénot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and seems to work
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
In the previous command, the
|&
was not a typo but intentional. Was removed outside of github AFAIK.The output of
php occ version
is onSTDERR
.Anyway, now this is a POSIX way to detect version.
☑️ Resolves
🖼️ Screenshots