Thanks to visit codestin.com
Credit goes to github.com

Skip to content

profiler docs: add version detection #12368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2025
Merged

Conversation

sputnick-dev
Copy link
Contributor

In the previous command, the |& was not a typo but intentional. Was removed outside of github AFAIK.

The output of php occ version is on STDERR.

Anyway, now this is a POSIX way to detect version.

☑️ Resolves

  • Fix #…

🖼️ Screenshots

Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@rakekniven
Copy link
Member

does not work on ubuntu 24.04
Got output: Warning:

@sputnick-dev
Copy link
Contributor Author

6 month later, still not merged?

@rakekniven
Copy link
Member

6 month later, still not merged?

Looks like.

Have you seen my comment?

@sputnick-dev
Copy link
Contributor Author

6 month later, still not merged?

Looks like.

Have you seen my comment?

You don't provide sufficient information.

Better copy/paste the whole execution commands with the proper cd

@rakekniven rakekniven requested a review from szaimen May 3, 2025 09:14
Copy link
Contributor Author

@sputnick-dev sputnick-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done required changes

@rakekniven

This comment was marked as outdated.

In the previous command, the `|&` was not a typo but intentional. Was removed outside of github AFAIK.

The output of `php occ version` is on `STDERR`.

Anyway, now this is a POSIX way to detect version.

Signed-off-by: Gilles Quénot <[email protected]>
Signed-off-by: Gilles Quénot <[email protected]>
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and seems to work

@szaimen szaimen changed the title Version detection profiler docs: add version detection May 5, 2025
@szaimen szaimen enabled auto-merge May 5, 2025 08:26
@szaimen szaimen merged commit 43682bd into nextcloud:master May 5, 2025
13 checks passed
@sputnick-dev sputnick-dev deleted the patch-2 branch May 5, 2025 10:29
Copy link
Contributor

github-actions bot commented May 6, 2025

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants