fix: use public Node API instead of internal View methods #908
+17
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14ef661 to
ee79dfa
Compare
Signed-off-by: nabim777 <[email protected]>
ee79dfa to
d14ec44
Compare
saw-jan
approved these changes
Oct 9, 2025
3cdf08d to
71a8c46
Compare
saw-jan
reviewed
Oct 9, 2025
saw-jan
reviewed
Oct 9, 2025
individual-it
approved these changes
Oct 9, 2025
There was a problem hiding this comment.
Looks good, and to prove it works we have an API test that still passes: https://github.com/nextcloud/integration_openproject/blob/master/tests/acceptance/features/api/getFileinfoByFileIDAPI.feature#L1355
Signed-off-by: nabim777 <[email protected]>
71a8c46 to
8a2cd47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following recent Nextcloud changes (#55574) where the View class marked as @internal, this PR replaces
DirectUploadControllerto use the recommendedNode APIinstead.A similar approach is used in other apps like files_zip
Documentation for the Node API used is available at:
https://docs.nextcloud.com/server/stable/developer_manual/basics/storage/filesystem.html#direct-storage-access
Related Issue or Workpackage
Screenshots (if appropriate):
Types of changes
Checklist:
CHANGELOG.mdfile