Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: use public Node API instead of internal View methods #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

fix: use public Node API instead of internal View methods #908

wants to merge 2 commits into from

Conversation

nabim777
Copy link
Collaborator

@nabim777 nabim777 commented Oct 8, 2025 •
edited
Loading

Description

Following recent Nextcloud changes (#55574) where the View class marked as @internal, this PR replaces DirectUploadController to use the recommended public Node API instead.

Related Issue or Workpackage

  • Fixes <issue_link>

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Updated CHANGELOG.md file

@nabim777 nabim777 self-assigned this Oct 8, 2025
@nabim777 nabim777 force-pushed the ci/fix-psalm-error branch 4 times, most recently from 14ef661 to ee79dfa Compare October 9, 2025 04:11
@nabim777 nabim777 force-pushed the ci/fix-psalm-error branch from ee79dfa to d14ec44 Compare October 9, 2025 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-nc julien-nc Awaiting requested review from julien-nc julien-nc will be requested when the pull request is marked ready for review julien-nc is a code owner

@individual-it individual-it Awaiting requested review from individual-it individual-it will be requested when the pull request is marked ready for review individual-it is a code owner

@ba1ash ba1ash Awaiting requested review from ba1ash ba1ash will be requested when the pull request is marked ready for review ba1ash is a code owner

@dominic-braeunlein dominic-braeunlein Awaiting requested review from dominic-braeunlein dominic-braeunlein will be requested when the pull request is marked ready for review dominic-braeunlein is a code owner

@Kharonus Kharonus Awaiting requested review from Kharonus Kharonus will be requested when the pull request is marked ready for review Kharonus is a code owner

@lindenthal lindenthal Awaiting requested review from lindenthal lindenthal will be requested when the pull request is marked ready for review lindenthal is a code owner

@psatyal psatyal Awaiting requested review from psatyal psatyal will be requested when the pull request is marked ready for review psatyal is a code owner

@saw-jan saw-jan Awaiting requested review from saw-jan saw-jan will be requested when the pull request is marked ready for review saw-jan is a code owner

@wielinde wielinde Awaiting requested review from wielinde wielinde will be requested when the pull request is marked ready for review wielinde is a code owner

@NobodysNightmare NobodysNightmare Awaiting requested review from NobodysNightmare NobodysNightmare will be requested when the pull request is marked ready for review NobodysNightmare is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@nabim777 nabim777

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nabim777