-
-
Notifications
You must be signed in to change notification settings - Fork 149
🎨 Migrate to outline icon style #2704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2513d24 to
e77f192
Compare
e77f192 to
bb644fc
Compare
Signed-off-by: Andy Scherzinger <[email protected]>
bb644fc to
8b48dc0
Compare
@jancborchardt what do you think? #2704 (comment) it is the icon we also use in all other clients and web at the moment, not sure there is an alternative we want to switch to. It is an outlined icon already after all. |
jancborchardt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but I think share internal link icon needs to be changed?
@jancborchardt what do you think? #2704 (comment) it is the icon we also use in all other clients and web at the moment, not sure there is an alternative we want to switch to. It is an outlined icon already after all.
Yeah, the icon looks good, I’m a bit confused as to why it would have to be changed? It’s outlined as you say.
Yes, the icon is outlined, but the circle background for the internal share link doesn't match the rest of the screen. I think having an outlined icon with filled background looks weird. I just noticed that, but we can skip it (or for now), since all the icons have been replaced correctly and the app is running without issues. Thanks for the input. |




No description provided.