Fix toolbar layout break on configuration change #2771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: alperozturk <[email protected]>
AndyScherzinger
approved these changes
Aug 5, 2025
Member
|
/backport to stable-4.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The layouts do not rely on alternate resource qualifiers, and any required UI adjustments are handled manually in the code. Therefore, it is acceptable to use:
android:configChanges="orientation|screenSize"to prevent the system from recreating the activity on configuration changes.Otherwise, if the layout depended on configuration-specific resources, such as different layouts for landscape mode or screen size variations, allowing the system to recreate the activity would be the preferred approach.
However, supporting this behavior would require restructuring the layout logic to make use of alternate resource directories, handling proper state restoration, and potentially rearchitecting parts of the UI to respond to different configurations.
Before
B4.mp4
After
A.mp4