Use embedded previews of ZIP-like files#20319
Merged
Conversation
skjnldsv
approved these changes
Apr 5, 2020
Member
skjnldsv
left a comment
There was a problem hiding this comment.
That is so awesome!!
Code looks good!
Maybe some tests? 🙈
Member
Author
|
Hm, not sure how I can properly write tests for that as the preview providers don't support DI yet. |
Member
Ah ok :) |
Member
Ah, that was not done! I was happy this looked so simple with the first commits 🙈 |
Member
Author
|
It is now, I just forgot to push a new file and bump the autoloader. |
lib/private/Preview/Krita.php
Outdated
| @@ -0,0 +1,53 @@ | |||
| <?php | |||
| /** | |||
| * @copyright Copyright (c) 2016, ownCloud, Inc. | |||
Contributor
|
Nice 👍 Works for me 🎉 server/config/config.sample.php Lines 981 to 1032 in 53db05a |
kesselb
approved these changes
Apr 5, 2020
Member
|
@juliushaertl please address the comments and we can get this in |
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
e843c89 to
5d27ed5
Compare
Member
Author
|
Done |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some filetypes like OpenDocument are basically just zip files and contain a preview image already that we can extract to provide previews without requiring external dependencies.
This implements an abstract class to extract as well as two providers for OpenDocument and Krita files.