Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[stable9] Print error message again, when 3rdparty submodule is not initialized#22

Merged
MariusBluem merged 1 commit intostable9from
fix-3rdparty-notice-stable9
Jun 8, 2016
Merged

[stable9] Print error message again, when 3rdparty submodule is not initialized#22
MariusBluem merged 1 commit intostable9from
fix-3rdparty-notice-stable9

Conversation

@blizzz
Copy link
Member

@blizzz blizzz commented Jun 8, 2016 •
edited
Loading

Could not find base or head reference on 3rdparty.

Could not find base or head reference on activity.

Could not find base or head reference on circles.

Could not find base or head reference on example-files.

Could not find base or head reference on files_pdfviewer.

Could not find base or head reference on files_rightclick.

Could not find base or head reference on files_videoplayer.

Could not find base or head reference on firstrunwizard.

Could not find base or head reference on logreader.

Could not find base or head reference on nextcloud_announcements.

Could not find base or head reference on notifications.

Could not find base or head reference on password_policy.

Could not find base or head reference on photos.

Could not find base or head reference on privacy.

Could not find base or head reference on recommendations.

Could not find base or head reference on serverinfo.

Could not find base or head reference on survey_client.

Could not find base or head reference on text.

Could not find base or head reference on updater.

Could not find base or head reference on viewer.

Could not find base or head reference on privacy.

Could not find base or head reference on recommendations.

Could not find base or head reference on viewer.

@blizzz blizzz added bug 3. to review Waiting for reviews labels Jun 8, 2016
@blizzz blizzz added this to the Nextcloud 9 milestone Jun 8, 2016
@MariusBluem
Copy link
Member

MariusBluem commented Jun 8, 2016 •
edited
Loading

👍

Question about the procedure: Why are we not merging the commit into stable9 form master, or from the origin brach - instead we create a fix-3rdparty-notice-stable9 branch 😕

@LukasReschke
Copy link
Member

LukasReschke commented Jun 8, 2016 •
edited
Loading

Question about the procedure: Why are we not merging the commit into stable9 form master, or from the origin brach - instead we create a fix-3rdparty-notice-stable9 branch 😕

We want to review every change to our stable or master branch manually. And since stable and master are often so different it's not feasible to do it that way since it would also get in new features etc :)

@blizzz Please review rebase so that CI runs on this as well :)

@blizzz
Print error message again, when 3rdparty submodule is not initialized
a49f5b7 
- old code used Response which attempted to use OC::$server which is not
and cannot be intialised at this part of the code.
@blizzz blizzz force-pushed the fix-3rdparty-notice-stable9 branch from bd82cd8 to a49f5b7 Compare June 8, 2016 10:26
@blizzz
Copy link
Member Author

blizzz commented Jun 8, 2016

rebased

@MariusBluem MariusBluem merged commit 73a9afe into stable9 Jun 8, 2016
@MariusBluem
Copy link
Member

MariusBluem commented Jun 8, 2016

All Tests passed - Backport merged 😉

@MariusBluem MariusBluem deleted the fix-3rdparty-notice-stable9 branch June 8, 2016 11:26
@blizzz
Copy link
Member Author

blizzz commented Jun 8, 2016

Yay, thx @Mar1u5 🙇

@nccguru nccguru mentioned this pull request Jun 22, 2016
Closed
@kuimovvg kuimovvg mentioned this pull request Mar 25, 2017
Closed
@MarioKlebsch MarioKlebsch mentioned this pull request Dec 4, 2017
Closed
@DarkAxi0m DarkAxi0m mentioned this pull request Dec 15, 2017
Closed
@jasondaigo jasondaigo mentioned this pull request Feb 13, 2018
Closed
@Yeru-314 Yeru-314 mentioned this pull request Feb 19, 2018
Closed
This was referenced Feb 22, 2018
Closed
Closed
@andreicociuba andreicociuba mentioned this pull request Mar 5, 2018
Closed
@warnerbryce warnerbryce mentioned this pull request Apr 30, 2018
Closed
@biljol biljol mentioned this pull request Jun 14, 2018
Closed
@dnsinformatic dnsinformatic mentioned this pull request Aug 23, 2018
Closed
@Gooberpatrol66 Gooberpatrol66 mentioned this pull request Sep 6, 2018
Closed
@lsbbs lsbbs mentioned this pull request Sep 7, 2018
Closed
@antoine-mesobfc antoine-mesobfc mentioned this pull request Oct 24, 2018
Closed
MorrisJobke added a commit that referenced this pull request Nov 9, 2018
@MorrisJobke
Catch and ignore UniqueConstraintViolationException in file locking init
6c48415 
* caused by a concurrect insert that happens between the INSERT and it's sub-SELECT which was there to actually avoid it within insertIfNotExists - sub selects are not atomic and allow this
* see also #12315

Avoids an error that has this stack trace:

```
Doctrine\DBAL\Exception\UniqueConstraintViolationException

An exception occurred while executing 'INSERT INTO "oc_file_locks" ("key","lock","ttl") SELECT ?,?,? FROM "oc_file_locks" WHERE "key" = ? HAVING COUNT(*) = 0' with params ["files/737d52477f1fb583a5bfe5eb33e820da", 1, 1524066628, "files/737d52477f1fb583a5bfe5eb33e820da"]:

SQLSTATE[23505]: Unique violation: 7 ERROR:  duplicate key value violates unique constraint "lock_key_index"
DETAIL:  Key (key)=(files/737d52477f1fb583a5bfe5eb33e820da) already exists.

 #0 3rdparty/doctrine/dbal/lib/Doctrine/DBAL/DBALException.php(128): Doctrine\DBAL\Driver\AbstractPostgreSQLDriver->convertException('An exception oc...', Object(Doctrine\DBAL\Driver\PDOException))
 #1 3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Connection.php(1015): Doctrine\DBAL\DBALException::driverExceptionDuringQuery(Object(Doctrine\DBAL\Driver\PDOPgSql\Driver), Object(Doctrine\DBAL\Driver\PDOException), 'INSERT INTO "oc...', Array)
 #2 lib/private/DB/Connection.php(213): Doctrine\DBAL\Connection->executeUpdate('INSERT INTO "oc...', Array, Array)
 #3 lib/private/DB/Adapter.php(114): OC\DB\Connection->executeUpdate('INSERT INTO "oc...', Array)\n#4 lib/private/DB/Connection.php(251): OC\DB\Adapter->insertIfNotExist('*PREFIX*file_lo...', Array, Array)\n#5 lib/private/Lock/DBLockingProvider.php(118): OC\DB\Connection->insertIfNotExist('*PREFIX*file_lo...', Array, Array)\n#6 lib/private/Lock/DBLockingProvider.php(163): OC\Lock\DBLockingProvider->initLockField('files/737d52477...', 1)
 #7 lib/private/Files/Storage/Common.php(704): OC\Lock\DBLockingProvider->acquireLock('files/737d52477...', 1)
 #8 lib/private/Files/View.php(1931): OC\Files\Storage\Common->acquireLock('files/Documents', 1, Object(OC\Lock\DBLockingProvider))
 #9 lib/private/Files/View.php(2041): OC\Files\View->lockPath('/*******/files/...', 1, false)
 #10 lib/private/Files/Node/Node.php(360): OC\Files\View->lockFile('/*******/files/...', 1)
 #11 apps/files_sharing/lib/Controller/ShareAPIController.php(928): OC\Files\Node\Node->lock(1)
 #12 apps/files_sharing/lib/Controller/ShareAPIController.php(589): OCA\Files_Sharing\Controller\ShareAPIController->lock(Object(OC\Files\Node\Folder))
 #13 [internal function]: OCA\Files_Sharing\Controller\ShareAPIController->getShares('true', 'false', 'false', Object(OC\Files\Node\Folder), 'false')
 #14 lib/private/AppFramework/Http/Dispatcher.php(160): call_user_func_array(Array, Array)
 #15 lib/private/AppFramework/Http/Dispatcher.php(90): OC\AppFramework\Http\Dispatcher->executeController(Object(OCA\Files_Sharing\Controller\ShareAPIController), 'getShares')
 #16 lib/private/AppFramework/App.php(114): OC\AppFramework\Http\Dispatcher->dispatch(Object(OCA\Files_Sharing\Controller\ShareAPIController), 'getShares')
 #17 lib/private/AppFramework/Routing/RouteActionHandler.php(47): OC\AppFramework\App::main('OCA\\Files_Shari...', 'getShares', Object(OC\AppFramework\DependencyInjection\DIContainer), Array)
 #18 [internal function]: OC\AppFramework\Routing\RouteActionHandler->__invoke(Array)
 #19 lib/private/Route/Router.php(299): call_user_func(Object(OC\AppFramework\Routing\RouteActionHandler), Array)
 #20 ocs/v1.php(78): OC\Route\Router->match('/ocsapp/apps/fi...')
 #21 ocs/v2.php(23): require_once('/usr/share/weba...')
 #22 {main}
````

Signed-off-by: Morris Jobke <[email protected]>
@andrewborell andrewborell mentioned this pull request Sep 4, 2019
Closed
@stoamandl stoamandl mentioned this pull request Mar 6, 2020
Closed
@LicoMonch LicoMonch mentioned this pull request Oct 8, 2020
Closed
@tuxcrafter tuxcrafter mentioned this pull request Dec 30, 2020
Closed
@jasysadmin jasysadmin mentioned this pull request Apr 11, 2021
Closed
@giacomo892 giacomo892 mentioned this pull request Jul 8, 2021
Closed
@xev-pcjc xev-pcjc mentioned this pull request Jul 8, 2021
Closed
This was referenced Jul 20, 2021
Closed
Closed
@skjnldsv skjnldsv mentioned this pull request Jul 23, 2021
Merged
@cyberpower678 cyberpower678 mentioned this pull request Sep 28, 2021
Closed
@kinimodmeyer kinimodmeyer mentioned this pull request Oct 1, 2021
Closed
@doc75 doc75 mentioned this pull request Feb 5, 2022
Closed
8 tasks
@PichlAlex PichlAlex mentioned this pull request Feb 10, 2022
Closed
8 tasks
@smooth-baking-powder smooth-baking-powder mentioned this pull request May 26, 2022
Closed
@Bevito Bevito mentioned this pull request Oct 12, 2022
Closed
9 tasks
@nowatbuer nowatbuer mentioned this pull request Jan 18, 2023
Closed
9 tasks
@soccerdmon11 soccerdmon11 mentioned this pull request Feb 8, 2023
Open
9 tasks
@OneTwoBarbecue OneTwoBarbecue mentioned this pull request Apr 8, 2023
Closed
9 tasks
@proserver1 proserver1 mentioned this pull request Sep 12, 2023
Closed
8 tasks
@adrhc adrhc mentioned this pull request Sep 17, 2024
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug

Projects

None yet

Milestone

Nextcloud 9

Development

Successfully merging this pull request may close these issues.

3 participants

@blizzz @MariusBluem @LukasReschke