add personal addtional setting section#22144
add personal addtional setting section#22144dassio wants to merge 1 commit intonextcloud:masterfrom dassio:personal-section
Conversation
|
are there anyone who can help to review this one ? |
juliusknorr
left a comment
There was a problem hiding this comment.
There seems to be an issue that the section will still be shown empty if no additional settings are available, could you look into that again?
|
Ah seems to be related to the this settings class: |
@ChristophWurst , can we delete this empty setting, or we have any paticular reason to keep it ? |
|
@juliushaertl @rullzer @kesselb please help to review |
|
can we merge this one now? I just did a rebase on master |
| * @since 9.1 | ||
| */ | ||
| public function getForm() { | ||
| return new TemplateResponse('settings', 'settings/empty'); |
There was a problem hiding this comment.
I'm not entirely sure about the complete removal yet, as it was a fallback for old settings registration iirc, so this would need to be checked if it still works.
There was a problem hiding this comment.
you are correct
I tried with this app Ebook Reader 1.4.2, is we remove this, we can't find the setting anymore
I will add it back
There was a problem hiding this comment.
I reverted it back and fix the duplicate addtional issue, not sure how to make the empty addtional go away
Sounds like #22144 @juliushaertl @nickvergessen 🤔 |
Signed-off-by: dassio <[email protected]>
|
blank addtional section removed @kesselb
|
Sorry. I don't know much about the settings area. It was not my intention to request changes. I just noticed the other pull requested and added a hint. We have to wait for the other reviews to specify the expected behaviour and how those pull requests work together. |
|
solved by #22589 |
|
Sorry @dassio I didn't see your PR before creating mine, and since the one line diff on my is easier I guess that is why it got merged. Thanks for the work anyway! |
|
in the developer manual settings section, there is a mentioning of
additionaldefault section, but it only appears on the admin part, not on the person part. resulting in apps that are meant for non-admin users can not use the default additional section, this pull request is to add the personal defaultAdditional settings