Thanks to visit codestin.com
Credit goes to github.com

Skip to content

LDAP simplify User_Proxy and Group_Proxy signatures#23620

Merged
blizzz merged 1 commit intomasterfrom
techdebt/noid/ldap-proxy-classes
Oct 26, 2020
Merged

LDAP simplify User_Proxy and Group_Proxy signatures#23620
blizzz merged 1 commit intomasterfrom
techdebt/noid/ldap-proxy-classes

Conversation

@blizzz
Copy link
Member

@blizzz blizzz commented Oct 22, 2020

… and look what a rat tail it had!

  • make User_Proxy and Group_Proxy easy to instantiate
  • simplify dependent code
  • move commands to info.xml
  • make UpdateGroups job class non-static

@blizzz blizzz added this to the Nextcloud 21 milestone Oct 22, 2020
@blizzz blizzz force-pushed the techdebt/noid/ldap-proxy-classes branch from 937576f to 13cd4b3 Compare October 22, 2020 09:51
@blizzz
Copy link
Member Author

blizzz commented Oct 22, 2020

the psalm.xml change fixes

Problem parsing /home/runner/work/server/server/psalm.xml:
  Could not resolve config path to /home/runner/work/server/server//apps/*/appinfo/register_command.php
Script psalm handling the psalm event returned with error code 1
Error: Process completed with exit code 1.

since this was the last register_command.php within apps/ dir and has been removed with this PR

MorrisJobke
MorrisJobke approved these changes Oct 22, 2020
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@MorrisJobke
Copy link
Member

MorrisJobke commented Oct 22, 2020

CI still has some errors due to changed constructor arguments.

@blizzz
Copy link
Member Author

blizzz commented Oct 22, 2020

CI still has some errors due to changed constructor arguments.

oh, indeed, slipped through

@blizzz blizzz force-pushed the techdebt/noid/ldap-proxy-classes branch from e5d4eb4 to add22f2 Compare October 22, 2020 10:51
@blizzz
LDAP simplify User_Proxy and Group_Proxy signatures
86e5e7d 
- make User_Proxy and Group_Proxy easy to instantiate
- simplify dependent code
- move commands to info.xml
- make UpdateGroups job class non-static

Signed-off-by: Arthur Schiwon <[email protected]>
@blizzz blizzz force-pushed the techdebt/noid/ldap-proxy-classes branch from add22f2 to 86e5e7d Compare October 23, 2020 10:25
nickvergessen
nickvergessen approved these changes Oct 26, 2020
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦈

@blizzz blizzz merged commit a744583 into master Oct 26, 2020
@blizzz blizzz deleted the techdebt/noid/ldap-proxy-classes branch October 26, 2020 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@julien-nc julien-nc Awaiting requested review from julien-nc

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

No one assigned

Labels

3. to review Waiting for reviews feature: ldap technical debt

Projects

None yet

Milestone

Nextcloud 21

Development

Successfully merging this pull request may close these issues.

3 participants

@blizzz @MorrisJobke @nickvergessen