Conversation
|
Fixes #24497 |
|
@blizzz Sorry for my noob question, but is there anything I should or could do to proceed this PR? The codesniffer check fails, but not on a line that I have manipulated. If from now on, it's all out of my hands, that's fine with me ;) |
2cde33e to
37f79f1
Compare
|
Fixes #24497 |
|
@blizzz ping? |
|
@blizzz just wanted to confirm that these patches still work on version 21.0.1. |
|
@blizzz Patches still work with newest version (22.2.3) |
|
@blizzz Patches still apply cleanly with version 22.2.5. System is running smoothly since the PR was created. @jospoortvliet Last ping from my end. First time collaborator to an open source project, and very disappointing to see absolutely noone cares. |
come-nc
left a comment
There was a problem hiding this comment.
See comments.
Please also run composer run cs:fix for code style.
Does this only work with openldap?
|
@zenlord any update here? :) |
37f79f1 to
b13e69e
Compare
|
@szaimen @blizzz @come-nc Finally got around resolving the comments made by @come-nc . Instead of doing a rebase, I have simply created a new clone, applied the original commits as a patch, made the code changes and then force-pushed the result to my fork. I hope this is acceptable, because going through all the merges required from rebasing against Nextcloud 20-something got dull very quickly :/ |
c415e59 to
489d0dd
Compare
…hp, Configuration.php, Wizard.php, LDAP.php and view.js Signed-off-by: Vincent Van Houtte <[email protected]>
489d0dd to
c323022
Compare
|
@come-nc Looks like this one is better: single commit and DCO is not complaining. |
|
25 is feature freezed so this will go into 26, waiting for 25 to branch out before merging into master. Thank you for this contribution @zenlord ! |
|
(actually needs 1 more review so I put back "to review" label) |
CarlSchwan
left a comment
There was a problem hiding this comment.
Need a rebase (last one hopefully)
Signed-off-by: Côme Chilliet <[email protected]>
|
/rebase |
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
This branch adds ldapi:/// connection support to the user_ldap app (both backend code and frontend code)