fixed publishing of user properties to lookup-server#25300
Closed
abangtor wants to merge 0 commit intonextcloud:masterfrom
Closed
fixed publishing of user properties to lookup-server#25300abangtor wants to merge 0 commit intonextcloud:masterfrom
abangtor wants to merge 0 commit intonextcloud:masterfrom
Conversation
kesselb
reviewed
Jan 26, 2021
Contributor
|
Thanks 👍 Please squash the commits together and we are good. |
| $publicData[$property->getName()] = $property->getValue(); | ||
| $publicData[$property->getName()] = [ | ||
| 'value' => $property->getValue(), | ||
| 'verified' => $property->getVerified() |
Member
There was a problem hiding this comment.
The lookup server also seems to check a signature at least for Twitter and website?
Contributor
There was a problem hiding this comment.
Mind to add how to get the signature? We talked briefly about the signature at #25290 and were lost ;)
|
Still not fixed in 2023. |
Contributor
|
Conflicts 😞 Sorry, I'm not familiar with lookup_server_connector and therefore cannot review it. |
Merged
Merged
Member
|
@ArtificialOwl you're our expert in lookup server, could you have a look when time allows? :) |
This was referenced Mar 12, 2024
Merged
Merged
Merged
Merged
Contributor
|
Reopening to review. Anything here that still needs to be done @abangtor ? We would like to help you get this one in :) |
Contributor
|
Rebasing went wrong - nevertheless copied the PR to the repo: #51229 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #25290
Fix of the bug in the lookup_server_connector module to publish public user information to the lookup-server.
There is a bug in the getUserAccountData method in the RetryJob.php of the lookup-server-connector module.
The properties are written into an one dimensional array $publicData:
server/apps/lookup_server_connector/lib/BackgroundJobs/RetryJob.php
Line 197 in 7668c86
Later on the array is read as it is a two dimensional array:
server/apps/lookup_server_connector/lib/BackgroundJobs/RetryJob.php
Lines 203 to 214 in 7668c86
This causes the values to be empty and no properties are send to the loopup-server.