Move files_external to IBootstrap and remove some deprecated stuff in the process#26319
Merged
MorrisJobke merged 6 commits intomasterfrom Jun 16, 2021
Merged
Move files_external to IBootstrap and remove some deprecated stuff in the process#26319MorrisJobke merged 6 commits intomasterfrom
MorrisJobke merged 6 commits intomasterfrom
Conversation
45b6e76 to
c0436c3
Compare
blizzz
approved these changes
Mar 26, 2021
Member
blizzz
left a comment
There was a problem hiding this comment.
👍 – sharepoint master also continues to work with this
MorrisJobke
reviewed
Mar 29, 2021
|
|
||
| protected function execute(InputInterface $input, OutputInterface $output): int { | ||
| $user = $input->getOption('user'); | ||
| $user = (string) $input->getOption('user'); |
Member
There was a problem hiding this comment.
The return value could be string|string[]|bool|null. MInd to remove this change for now and then we look into make this correct?
Member
Author
There was a problem hiding this comment.
psalm wants the cast
Member
There was a problem hiding this comment.
But casting an array to string will cause issues, no?
Signed-off-by: Robin Appelman <[email protected]>
c0436c3 to
94f0c10
Compare
Signed-off-by: Robin Appelman <[email protected]>
Member
|
rebased |
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Arthur Schiwon <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.