Removing useless call to external class#26890
Closed
ArtificialOwl wants to merge 1 commit intomasterfrom
Closed
Conversation
skjnldsv
approved these changes
May 7, 2021
Member
Author
done, mb. |
skjnldsv
approved these changes
May 7, 2021
Member
|
squash? |
2348ae6 to
d26164b
Compare
Member
Author
|
squashed |
Member
|
thanks for squashing |
juliusknorr
approved these changes
May 10, 2021
Member
|
Psalm baseline needs an update https://github.com/nextcloud/server/pull/26890/checks?check_run_id=2530339318 |
Merged
732f678 to
3ed8c99
Compare
Member
Author
looks good now |
Member
|
let me fix psalm here and then this can be merged. |
Signed-off-by: Maxence Lange <[email protected]>
3ed8c99 to
e437ae0
Compare
Member
|
Drone was green - only psalm was red: https://drone.nextcloud.com/nextcloud/server/5224 |
Member
|
Psalm is unhappy ... seems that the code was actually needed. |
Member
Author
|
let's close this, I fixed the API on my side. This will be rewrite using an API included to Core in NC23 anyway |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redundant check done in the provider itself, useless in here