Merged
Conversation
70633d6 to
9f313bb
Compare
a7799d5 to
db62eb4
Compare
e3f286d to
ae3fe4d
Compare
a47399e to
3aaadbf
Compare
3aaadbf to
31f7f14
Compare
727250a to
4ebb61e
Compare
| if (empty($this->value)) { | ||
| return null; | ||
| } | ||
| return 'mailto:' . $this->value; |
Member
There was a problem hiding this comment.
As per @tobiasKaminsky this will make sure the profiles API needs a rewrite when we want to bring all the actions to the clients. We should return the bare values and the rendering should make it a link or something like that?
blizzz
reviewed
Oct 18, 2021
1310e35 to
f85cf8f
Compare
ChristophWurst
approved these changes
Oct 18, 2021
Member
ChristophWurst
left a comment
There was a problem hiding this comment.
Reviewed public API part and give it a smoke test
👍 
ab04da4 to
e707e3c
Compare
- New properties - Organisation - Role - Headline - Biography - Profile Enabled property - Fix errors with building default account properties - Fix L10N factory method `getLanguage` not public error - Update tests Signed-off-by: Christopher Ng <[email protected]>
e707e3c to
337eeb2
Compare
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
337eeb2 to
3be9d3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tasks
Additional email actionsVisual Reference
Profile page
Settings page
Contributes to #28139