Conversation
e5185f4 to
fd5ad5c
Compare
099f95a to
733d015
Compare
Merged
9fc8fad to
a28c72d
Compare
This comment has been minimized.
This comment has been minimized.
dc07da1 to
02629da
Compare
Contributor
Author
Changed to |
skjnldsv
approved these changes
Oct 14, 2021
Member
skjnldsv
left a comment
There was a problem hiding this comment.
Code looks good. Thanks for the tests too! 👍
juliusknorr
requested changes
Oct 14, 2021
Member
juliusknorr
left a comment
There was a problem hiding this comment.
Tested with some small adjustment that would need a fix, works good with that otherwise and code also looks nice an clean 👍
PVince81
approved these changes
Oct 14, 2021
Member
PVince81
left a comment
There was a problem hiding this comment.
Code looks good in general, great to see many tests.
I only had minor comments
👍
a34b31b to
4180a79
Compare
Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
79a3c08 to
8dbaeda
Compare
Member
|
Tests failure unrelated |
Member
|
Once @juliushaertl confirmed, we can get this in 🚀 |
juliusknorr
approved these changes
Oct 16, 2021
Signed-off-by: Louis Chemineau <[email protected]>
8dbaeda to
def983d
Compare
Member
|
Pushed a fix for the failing capabilities test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #28443
The PR adds a new DAV plugin to handle requests on the
/dav/bulkendpoint.bulkuploadRequest templates
bec011bf527a43d6is a random stringContent-LengthheaderResponse template
{ "/path/for/file/n/1": "ETag of the written file", "/path/for/file/n/2": "ETag of the written file", .... }Benchmarks
This PR contains some benchmarks written in bash. They are be flexible enough to test different file counts, file sizes, bandwidth and concurrency.