Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix immutable datetime handling in DAV calendar search#29481

Merged
ChristophWurst merged 1 commit intomasterfrom
fix/dav-calendar-query-start-end-immutable
Oct 28, 2021
Merged

Fix immutable datetime handling in DAV calendar search#29481
ChristophWurst merged 1 commit intomasterfrom
fix/dav-calendar-query-start-end-immutable

Conversation

@ChristophWurst
Copy link
Member

With the new API from #28970 we get immutable datetime objects. These do not extend the mutable datetime class, hence the options were silently ignored. With this patch the new calendar query API can scope by dates.

@ChristophWurst ChristophWurst added this to the Nextcloud 23 milestone Oct 28, 2021
@ChristophWurst ChristophWurst requested review from a team, miaulalala and tcitworld October 28, 2021 16:38
@ChristophWurst ChristophWurst self-assigned this Oct 28, 2021
@ChristophWurst ChristophWurst requested review from PVince81, nickvergessen and skjnldsv and removed request for a team October 28, 2021 16:38
@tcitworld
Copy link
Member

You can use instanceof DateTimeInterface instead. https://www.php.net/manual/en/class.datetimeinterface.php

@ChristophWurst ChristophWurst force-pushed the fix/dav-calendar-query-start-end-immutable branch from d2b19b6 to 2956f1c Compare October 28, 2021 17:45
@ChristophWurst ChristophWurst merged commit 2d698cc into master Oct 28, 2021
@ChristophWurst ChristophWurst deleted the fix/dav-calendar-query-start-end-immutable branch October 28, 2021 20:15
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2021
19 tasks
@blizzz blizzz mentioned this pull request Nov 3, 2021
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants