Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Harden disk_free_space check in CheckSetupController#30608

Merged
artonge merged 1 commit intomasterfrom
harden-fonct
Oct 10, 2022
Merged

Harden disk_free_space check in CheckSetupController#30608
artonge merged 1 commit intomasterfrom
harden-fonct

Conversation

@solracsf
Copy link
Member

@solracsf solracsf commented Jan 11, 2022

To avoid things like #26034

@solracsf solracsf added the 3. to review Waiting for reviews label Jan 11, 2022
@solracsf
Copy link
Member Author

solracsf commented Jan 11, 2022

/backport to stable23

@solracsf
Copy link
Member Author

solracsf commented Jan 11, 2022

/backport to stable22

@solracsf
Copy link
Member Author

solracsf commented Jan 11, 2022

/backport to stable21

artonge
artonge reviewed Jan 13, 2022
View reviewed changes
@solracsf solracsf changed the title Harden some PHP functions in CheckSetupController Harden disk_free_space check in CheckSetupController Jan 20, 2022
@szaimen
Copy link
Contributor

szaimen commented Apr 7, 2022

/rebase

@szaimen szaimen added this to the Nextcloud 24 milestone Apr 7, 2022
@szaimen
Copy link
Contributor

szaimen commented Apr 7, 2022

@solracsf please fix dco and can you squash this? Thanks!

@blizzz blizzz mentioned this pull request Apr 13, 2022
Merged
@blizzz blizzz modified the milestones: Nextcloud 24, Nextcloud 25 Apr 21, 2022
This was referenced Aug 12, 2022
Merged
Merged
This was referenced Aug 24, 2022
Merged
Merged
@blizzz blizzz mentioned this pull request Sep 6, 2022
Merged
@solracsf
Copy link
Member Author

solracsf commented Sep 6, 2022

/rebase

@szaimen
Copy link
Contributor

szaimen commented Sep 6, 2022

@solracsf please fix dco and can you squash this? Thanks!

Otherwise we cannot merge this...

@blizzz blizzz mentioned this pull request Sep 9, 2022
Merged
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
Merged
@blizzz blizzz mentioned this pull request Sep 20, 2022
Closed
@solracsf solracsf closed this Oct 3, 2022
@solracsf solracsf deleted the harden-fonct branch October 3, 2022 18:29
@artonge
Copy link
Contributor

artonge commented Oct 4, 2022

Any reason this was closed @solracsf ?

@solracsf
Copy link
Member Author

solracsf commented Oct 4, 2022

8 months and a simple squash blocking a PR...feel free to reopen, squash and merge.

@artonge artonge restored the harden-fonct branch October 4, 2022 11:10
@artonge artonge reopened this Oct 4, 2022
@artonge artonge force-pushed the harden-fonct branch 2 times, most recently from 0d3f3fc to 717ec4b Compare October 4, 2022 11:21
@solracsf @artonge
Harden some PHP functions
4207b80 
To avoid things like #26034

Signed-off-by: Louis Chemineau <[email protected]>
@artonge artonge self-assigned this Oct 4, 2022
@szaimen
Copy link
Contributor

szaimen commented Oct 4, 2022

8 months and a simple squash blocking a PR...feel free to reopen, squash and merge.

The problem was mostly the missing DCO. Otherwise I would have done it for you.

szaimen
szaimen reviewed Oct 4, 2022
View reviewed changes
@artonge artonge merged commit f456989 into master Oct 10, 2022
@artonge artonge deleted the harden-fonct branch October 10, 2022 13:42
@artonge
Copy link
Contributor

artonge commented Oct 10, 2022

/backport to stable25

@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Oct 10, 2022

The backport to stable25 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Oct 10, 2022

The backport to stable23 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Oct 10, 2022

The backport to stable22 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Oct 10, 2022

The backport to stable21 failed. Please do this backport manually.

@artonge
Copy link
Contributor

artonge commented Oct 10, 2022

/backport to stable25

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Oct 10, 2022
Merged
@artonge
Copy link
Contributor

artonge commented Oct 10, 2022

/backport to stable24

@artonge
Copy link
Contributor

artonge commented Oct 10, 2022

/backport to stable23

This was referenced Oct 10, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@szaimen szaimen szaimen left review comments

@artonge artonge artonge approved these changes

@MichaIng MichaIng MichaIng approved these changes

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

Assignees

@artonge artonge

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

Nextcloud 26

Development

Successfully merging this pull request may close these issues.

6 participants

@solracsf @szaimen @artonge @CarlSchwan @MichaIng @blizzz